arina-ielchiieva commented on a change in pull request #2018: DRILL-7633: Fixes for union and repeated list accessors URL: https://github.com/apache/drill/pull/2018#discussion_r397109336
########## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/VariantColumnMetadata.java ########## @@ -145,16 +147,28 @@ public ColumnMetadata cloneEmpty() { @Override public ColumnMetadata copy() { - // TODO Auto-generated method stub - assert false; - return null; + return new VariantColumnMetadata(name, type, mode, variantSchema.copy()); } @Override public VariantMetadata variantSchema() { return variantSchema; } + @JsonProperty("type") Review comment: Remove json property annotation as it will be present in parent class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services