arina-ielchiieva commented on a change in pull request #2039: DRILL-7663: Code
refactor to DefaultFunctionResolver
URL: https://github.com/apache/drill/pull/2039#discussion_r397879964
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/resolver/DefaultFunctionResolver.java
##########
@@ -38,12 +38,11 @@ public DrillFuncHolder getBestMatch(List<DrillFuncHolder>
methods, FunctionCall
int currcost = Integer.MAX_VALUE;
DrillFuncHolder bestmatch = null;
final List<DrillFuncHolder> bestMatchAlternatives = new LinkedList<>();
-
+ List<TypeProtos.MajorType> argumentTypes = Lists.newArrayList();
Review comment:
Well, it's just a suggestion... it's looks much better though.
If you want to leave as it you are welcome but then replace
`Lists.newArrayList();` Guava usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
