vvysotskyi commented on a change in pull request #2038: DRILL-6604: Upgrade
Drill Hive client to Hive3.1 version
URL: https://github.com/apache/drill/pull/2038#discussion_r399169874
##########
File path:
contrib/storage-hive/core/src/test/java/org/apache/drill/exec/impersonation/hive/BaseTestHiveImpersonation.java
##########
@@ -97,11 +99,29 @@ protected static void prepHiveConfAndData() throws
Exception {
}
protected static void startHiveMetaStore() throws Exception {
- final int port = MetaStoreUtils.findFreePort();
+ Class<?> metaStoreUtilsClass;
+ Class<?> hadoopThriftAuthBridgeClass;
+ Class<?> confClass;
+ Object hadoopThriftAuthBridge;
+ // TODO: remove reflection stuff when all supported profiles will be
switched to Hive 3+ version
Review comment:
Currently, we support only a single non-default profile, but it hasn't
released Hive 3+ versions, so I think that it would be better to postpone the
creation of the Jira to the time when it is released (if it will be released),
so we will know the exact version.
But I have created another Jira in Hive - HIVE-23088 to be able to remove
workaround with logger class after this issue is fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
