arina-ielchiieva commented on a change in pull request #2024: DRILL-7641
Convert Excel Reader to use Streaming Reader
URL: https://github.com/apache/drill/pull/2024#discussion_r399236022
##########
File path:
contrib/format-excel/src/test/java/org/apache/drill/exec/store/excel/TestExcelFormat.java
##########
@@ -339,11 +339,12 @@ public void testInconsistentDataQuery() throws Exception
{
testBuilder()
.sqlQuery(sql)
- .ordered().baselineColumns("col1", "col2")
- .baselineValues("1.0", "Bob")
- .baselineValues("2.0", "Steve")
- .baselineValues("3.0", "Anne")
- .baselineValues("Bob", "3.0")
+ .ordered()
Review comment:
Your test does not include order by thus returned result order is
unpredictable. Please change to unordered here and in other tests above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
