paul-rogers commented on a change in pull request #2043: DRILL-7673: View set
query fails with NPE for non-existing option
URL: https://github.com/apache/drill/pull/2043#discussion_r399613760
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SetOptionHandler.java
##########
@@ -63,9 +64,10 @@ public final PhysicalPlan getPlan(SqlNode sqlNode) throws
ForemanSetupException
SqlNode optionValue = statement.getValue();
if (optionValue == null) {
+ OptionDefinition optionDefinition =
optionManager.getOptionDefinition(optionName);
Review comment:
Probably worth a comment saying that this call will validate the option to
ensure it is valid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
