paul-rogers commented on issue #1892: DRILL-7437: Storage Plugin for Generic 
HTTP REST API
URL: https://github.com/apache/drill/pull/1892#issuecomment-608171729
 
 
   Added support to configure the HTTP proxy from environment variables or the 
`drill-override.conf` file. Added tests for this case. The HTTP storage plugin 
proxy config is added in "on top.". Updated the `README.md` file.
   
   During this work I did a full review of the code (and made any changes that 
were needed.)
   
   Suggestion: this is getting pretty far along. @cgivre, I suggest you take a 
final pass to ensure all is to your liking. Then, squash commits. After that, 
perhaps @arina-ielchiieva can give a final review and the approval. (Since I'm 
a co-author on this one, I don't want to approve my own changes.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to