paul-rogers commented on a change in pull request #1892: DRILL-7437: Storage
Plugin for Generic HTTP REST API
URL: https://github.com/apache/drill/pull/1892#discussion_r402761625
##########
File path:
contrib/storage-kudu/src/main/java/org/apache/drill/exec/store/kudu/KuduStoragePlugin.java
##########
@@ -35,15 +35,20 @@
private final KuduSchemaFactory schemaFactory;
private final KuduClient client;
-
public KuduStoragePlugin(KuduStoragePluginConfig configuration,
DrillbitContext context, String name)
- throws IOException {
+ throws IOException {
super(context, name);
this.schemaFactory = new KuduSchemaFactory(this, name);
this.engineConfig = configuration;
this.client = new
KuduClient.KuduClientBuilder(configuration.getMasterAddresses()).build();
}
+
+ @Override
+ public void start() throws IOException {
+
+ }
Review comment:
Is this change intentional? Or an artifact of rebasing? I suspect I removed
this method in some PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
