paul-rogers commented on a change in pull request #2056: DRILL-7701: EVF V2
Scan Framework
URL: https://github.com/apache/drill/pull/2056#discussion_r410816122
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/file/FileScanUtils.java
##########
@@ -38,7 +38,7 @@ public static String partitionColName(int partition) {
}
public static List<SchemaPath> expandMetadata(int dirCount) {
- List<String> selected = Arrays.asList(
+ List<String> selected = Lists.newArrayList(
Review comment:
Agreed. However, `Arrays.asList()` produces an immutable list, whereas here
we need a mutable list so we can add a few more items. Is there a JDK method
that will do what we need?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
