arina-ielchiieva commented on a change in pull request #2062: DRILL-7711: Add
data path, parameter filter pushdown to HTTP plugin
URL: https://github.com/apache/drill/pull/2062#discussion_r410914165
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/json/parser/RootParser.java
##########
@@ -40,13 +44,31 @@ public RootParser(JsonStructureParser structParser) {
this.rootObject = new ObjectParser(this, structParser.rootListener());
}
+ /**
+ * Parse one data object. This is the "root" object which may contain
+ * nested objects. Overridden to handle different end-of-data indicators
+ * for different contexts.
+ *
+ * @return {@code true} if an object was found, {@code false} if the
+ * end of data was reached.
+ */
public abstract boolean parseRoot(TokenIterator tokenizer);
+ // Generic parsing no allowed at the root since the root must
+ // report EOF. Use parseRoot() instead.
@Override
public void parse(TokenIterator tokenizer) {
throw new UnsupportedOperationException();
Review comment:
Add error message please instead of comment in code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
