vvysotskyi commented on a change in pull request #2071:
URL: https://github.com/apache/drill/pull/2071#discussion_r419654433
##########
File path: contrib/native/client/CMakeLists.txt
##########
@@ -25,6 +25,13 @@ cmake_policy(SET CMP0043 NEW)
cmake_policy(SET CMP0048 NEW)
enable_testing()
+#
+# required version for dependencies
+#
+set (BOOST_MINIMUM_VERSION 1.54.0)
+set (PROTOBUF_MINIMUM_VERSION 3.6.1)
Review comment:
protoc compiler is required to be installed when regenerating c++
protobuf files, not java classes, therefore I pointed to that PRs in my
previous comment.
But this change doesn't make things worse, so it may be merged as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
