cgivre commented on a change in pull request #2075:
URL: https://github.com/apache/drill/pull/2075#discussion_r421729696
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DumpCat.java
##########
@@ -250,7 +250,7 @@ private void showSingleBatch (VectorAccessibleSerializable
vcSerializable, boole
System.out.println(getBatchMetaInfo(vcSerializable).toString());
System.out.println("Schema Information");
- for (final VectorWrapper w : vectorContainer) {
+ for (final VectorWrapper<?> w : vectorContainer) {
final MaterializedField field = w.getValueVector().getField();
System.out.println (String.format("name : %s, minor_type : %s,
data_mode : %s",
Review comment:
Do we want a `System.out.println()` here?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogsResources.java
##########
@@ -190,9 +190,9 @@ public int compareTo(Log log) {
@XmlRootElement
public class LogContent {
- private String name;
- private Collection<String> lines;
- private int maxLines;
+ private final String name;
+ private final Collection<String> lines;
+ private final int maxLines;
@JsonCreator
public LogContent (@JsonProperty("name") String name,
@JsonProperty("lines") Collection<String> lines, @JsonProperty("maxLines") int
maxLines) {
Review comment:
nit: New lines here perhaps?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
