cgivre commented on a change in pull request #2069:
URL: https://github.com/apache/drill/pull/2069#discussion_r429670719
##########
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -75,7 +83,9 @@
private Row currentRow;
- private Workbook workbook;
+ private StreamingWorkbook swb;
+
+ private CoreProperties fileMetadata;
Review comment:
Yeah, so both the workbook and the `fileMetadata` fields are called a
few times later in the reader. It seemed to make sense to create class
variables for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
