cgivre commented on pull request #2112: URL: https://github.com/apache/drill/pull/2112#issuecomment-728662493
Hi @nielsbasjes I fixed all the data type issues and I think this is ready for another round of review. I'm going to hold off on adding the UA parser directly to this for now as I'd like to get this committed. I will say that I'm pleasantly surprised by the speed of this parser now. With the sample files I've queried, the results are noticeably faster and in some cases near instantaneous! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
