cgivre commented on a change in pull request #2127:
URL: https://github.com/apache/drill/pull/2127#discussion_r550954457
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/StoragePluginRegistryImpl.java
##########
@@ -420,9 +420,13 @@ public void validatedPut(String name, StoragePluginConfig
config)
PluginHandle entry = restoreFromEphemeral(name, config);
try {
entry.plugin();
+ } catch (UserException e) {
+ // Provide helpful error messages.
+ throw new PluginException(e.getOriginalMessage(), e);
} catch (Exception e) {
throw new PluginException(String.format(
- "Invalid plugin config for '%s'", name), e);
+ "Invalid plugin config for '%s', "
+ + "Please switch to Logs panel from the UI then check the log.",
name), e);
Review comment:
@luocooong
Does the exception message have anything useful in it? Could we include
`e.getMessage()` in the message which is returned?
If you don't think that would be helpful, I'm fine with committing as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
