vdiravka commented on a change in pull request #2154:
URL: https://github.com/apache/drill/pull/2154#discussion_r563289353
##########
File path: exec/java-exec/src/main/resources/rest/alertModals.ftl
##########
@@ -105,9 +108,13 @@
msgHeader:" ERROR: No Query to execute",
msgBody:"Please provide a query. The query textbox cannot be
empty."
},
+ "pluginEnablingFailure": {
+ msgHeader:" ERROR: Unable to enable/disable plugin",
+ msgBody:"<span
style='font-family:courier;white-space:pre'>_pluginName_</span>: _errorMessage_"
+ },
"errorId": {
msgHeader:"~header~",
msgBody:"Description unavailable"
}
}
-</script>
\ No newline at end of file
+</script>
Review comment:
```suggestion
</script>
```
##########
File path: exec/java-exec/src/main/resources/rest/alertModals.ftl
##########
@@ -105,9 +108,13 @@
msgHeader:" ERROR: No Query to execute",
msgBody:"Please provide a query. The query textbox cannot be
empty."
},
+ "pluginEnablingFailure": {
+ msgHeader:" ERROR: Unable to enable/disable plugin",
Review comment:
What about reason of why it is impossible to enable the specific storage
plugin?
Is that possible to show the message from the storage?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java
##########
@@ -169,6 +170,17 @@ public JsonResult enablePlugin(@PathParam("name") String
name, @PathParam("val")
}
}
+ /**
+ * @deprecated use the method with POST request {@link #enablePlugin} instead
Review comment:
Possibly it is better to do it after one major release. Because of this
is REST API, some tools can still use old api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
