cgivre commented on a change in pull request #2089: URL: https://github.com/apache/drill/pull/2089#discussion_r571650698
########## File path: contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkScanBatchCreator.java ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.splunk; + +import org.apache.drill.common.exceptions.ExecutionSetupException; +import org.apache.drill.common.exceptions.UserException; +import org.apache.drill.common.types.TypeProtos.MinorType; +import org.apache.drill.common.types.Types; +import org.apache.drill.exec.ops.ExecutorFragmentContext; +import org.apache.drill.exec.physical.impl.BatchCreator; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedReader; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedScanFramework; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedScanFramework.ReaderFactory; +import org.apache.drill.exec.physical.impl.scan.framework.ManagedScanFramework.ScanFrameworkBuilder; +import org.apache.drill.exec.physical.impl.scan.framework.SchemaNegotiator; +import org.apache.drill.exec.record.CloseableRecordBatch; +import org.apache.drill.exec.record.RecordBatch; +import org.apache.drill.exec.server.options.OptionManager; +import org.apache.drill.shaded.guava.com.google.common.base.Preconditions; + +import java.util.List; + +public class SplunkScanBatchCreator implements BatchCreator<SplunkSubScan> { + + @Override + public CloseableRecordBatch getBatch(ExecutorFragmentContext context, + SplunkSubScan subScan, List<RecordBatch> children) throws ExecutionSetupException { + Preconditions.checkArgument(children.isEmpty()); + + try { + ScanFrameworkBuilder builder = createBuilder(context.getOptions(), subScan); + return builder.buildScanOperator(context, subScan); + } catch (UserException e) { + // Rethrow user exceptions directly + throw e; + } catch (Throwable e) { + // Wrap all others + throw new ExecutionSetupException(e); + } + } + + private ScanFrameworkBuilder createBuilder(OptionManager options, SplunkSubScan subScan) { + SplunkPluginConfig config = subScan.getConfig(); + ScanFrameworkBuilder builder = new ScanFrameworkBuilder(); + builder.projection(subScan.getColumns()); + builder.setUserName(subScan.getUserName()); + + // Reader + ReaderFactory readerFactory = new SplunkReaderFactory(config, subScan); + builder.setReaderFactory(readerFactory); + builder.nullType(Types.optional(MinorType.VARCHAR)); + return builder; + } + + private static class SplunkReaderFactory implements ReaderFactory { + + private final SplunkPluginConfig config; + private final SplunkSubScan subScan; + private int count; + + public SplunkReaderFactory(SplunkPluginConfig config, SplunkSubScan subScan) { + this.config = config; + this.subScan = subScan; + } + + @Override + public void bind(ManagedScanFramework framework) { + } + + @Override + public ManagedReader<SchemaNegotiator> next() { + // Only a single scan (in a single thread) + if (count++ == 0) { + return new SplunkBatchReader(config, subScan); + } + return null; + } + } +} Review comment: Fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
