vvysotskyi commented on a change in pull request #2184:
URL: https://github.com/apache/drill/pull/2184#discussion_r585908797
##########
File path:
contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java
##########
@@ -125,7 +125,7 @@ public boolean next() {
private void openFile(FileSchemaNegotiator negotiator) {
try {
- fileReaderShp = negotiator.fileSystem().open(split.getPath());
+ fileReaderShp =
negotiator.fileSystem().openDecompressedInputStream(split.getPath());
Review comment:
Both methods `openPossiblyCompressedStream()` and
`openDecompressedInputStream()` have similar logic in determining compression
codec (based on specified path) and producing decompression. The difference is
only that the last one places whole the stream to the buffer and wraps it to
the `ByteArrayInputStream`. So looks like if `openDecompressedInputStream()`
will not help, the `openPossiblyCompressedStream()` also wouldn't work.
If for some reason files from s3 are read as compressed, and there is no way
for obtaining info for the compression method when reading the file, we can add
a property to the file storage plugin `config` block that will hold the default
compression type if any.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
