luocooong commented on pull request #2191:
URL: https://github.com/apache/drill/pull/2191#issuecomment-808867026
> The most common issues that I suppressed involved null values and
potential NPE and override hashcode and equals. The thing with the null values
is that, most times in the codebase, if the value was null it would already be
dealt with (via null guard or logger); however, it still marks it as an alert.
With hashcode and equals, there were sometimes a need for only hashcode and not
equals, and vice versa. If one or the other were not present in the file, it
would throw an alert. Also, in some cases, the equals function was there, but
it was not named equals (it was named impEquals), which LGTM prob did not pick
up, and threw the alert.
I have noticed your question. Before resolve, I would like to ask you to
research the following:
1. How does LGTM.com work?
2. Are all alarms meaningful on LGTM.com (Help focus your mind)?
3. Could you please explain what is LGTM's suggestions for handle the
issues (NPE, hashcode)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
