paul-rogers commented on pull request #2183: URL: https://github.com/apache/drill/pull/2183#issuecomment-812925090
@luocooong, thanks for the question. I raised several issues. I'll leave it to the team to decide whether to worry about those issues, or just wait for someone to report new bugs. My tendency is, once I become aware of an issue, to fix it if doing so is quick; I find that more efficient than waiting for some poor user to hit the issue, debug the problem, report the bug, get the bug prioritized, and go through another code review cycle. But, that's just me. My suggestion would be to inspect and, if necessary, fix all the buffer issues in the file that contains the concat functions. An "extra for experts" is to change the code in the concat functions that works with null values to *not* inspect the null value, as, in the general case, it can be invalid. Of course, we don't know that these are problems, probably because we have no good tests. So, if you are of the "test driven development" persuasion, I'd encourage writing a few tests to verify behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
