cgivre commented on a change in pull request #2143:
URL: https://github.com/apache/drill/pull/2143#discussion_r618332415
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
##########
@@ -263,10 +258,11 @@ private void newSchema() throws IOException {
.withAllocator(new ParquetDirectByteBufferAllocator(oContext))
.withValuesWriterFactory(new DefaultV1ValuesWriterFactory())
.build();
- pageStore = new
ParquetColumnChunkPageWriteStore(codecFactory.getCompressor(codec), schema,
initialSlabSize,
- pageSize, parquetProperties.getAllocator(),
parquetProperties.getPageWriteChecksumEnabled(),
- parquetProperties.getColumnIndexTruncateLength()
- );
+ // TODO: Replace ParquetColumnChunkPageWriteStore with
ColumnChunkPageWriteStore from parquet library
+ // once PARQUET-1006 will be resolved
Review comment:
@vdiravka Could you please create a JIRA for this and any other TODOs
from this PR?
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/ParquetSimpleTestFileGenerator.java
##########
@@ -46,7 +46,8 @@
* that are supported by Drill. Embedded types specified in the Parquet
specification are not covered by the
* examples but can be added.
* To create a new parquet file, define a schema, create a GroupWriter based
on the schema, then add values
- * for individual records to the GroupWriter.
+ * for individual records to the GroupWriter.<br>
+ * TODO: to run this tool please use 28.2-jre <guava.version> instead of
19.0 in main POM file
Review comment:
See comment above re: TODOs. I know you already created one, but could
you please update the comment with the JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
