cgivre commented on a change in pull request #2216:
URL: https://github.com/apache/drill/pull/2216#discussion_r626875021
##########
File path: contrib/storage-kudu/pom.xml
##########
@@ -57,7 +57,7 @@
<dependency>
<groupId>org.apache.kudu</groupId>
<artifactId>kudu-client</artifactId>
- <version>1.3.0</version>
+ <version>1.14.0</version>
Review comment:
> We have two ignored test classes here, and one of them has code that
creates tables in Kudu, and another one queries them. Could you please enable
and update them to use the Kudu instance from test containers?
The unit tests for this plugin are frankly pretty poor. I'll figure out
`testcontainers` and update. Do you think I should break that out in a
separate PR? I'd really like to refactor the unit tests for Kudu if we're
going to continue supporting it, and that represents a lot more work than I
intended in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
