vvysotskyi commented on a change in pull request #2200:
URL: https://github.com/apache/drill/pull/2200#discussion_r633233309
##########
File path:
contrib/storage-kafka/src/test/java/org/apache/drill/exec/store/kafka/KafkaFilterPushdownTest.java
##########
@@ -419,13 +419,13 @@ public void testNoPushdownOfOffsetWithNonMetadataField()
throws Exception {
final int expectedRowCount = 30;
final String queryString =
String.format(TestQueryConstants.QUERY_TEMPLATE_AND_OR_PATTERN_2,
- TestQueryConstants.JSON_PUSHDOWN_TOPIC, predicate1, predicate2,
predicate3);
+ TestQueryConstants.JSON_PUSHDOWN_TOPIC, predicate1, predicate2,
predicate3);
runKafkaSQLVerifyCount(queryString,expectedRowCount);
queryBuilder()
- .sql(queryString)
- .jsonPlanMatcher()
- .include(String.format(EXPECTED_PATTERN, expectedRowCountInPlan))
- .match();
+ .sql(queryString)
+ .jsonPlanMatcher()
+ .include(String.format(EXPECTED_PATTERN, expectedRowCountInPlan))
+ .match();
}
-}
+}
Review comment:
Please revert formatting changes here and in other places. It is fine to
have 4 spaces for the case when moving builder methods or arguments on the new
line and having an empty line at the end of the class.
##########
File path: contrib/storage-kafka/pom.xml
##########
@@ -86,6 +86,25 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.101tec</groupId>
+ <artifactId>zkclient</artifactId>
+ <version>0.11</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka_2.12</artifactId>
+ <version>${kafka.version}</version>
+ <classifier>test</classifier>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.servicemix.bundles</groupId>
+ <artifactId>org.apache.servicemix.bundles.kafka_2.12</artifactId>
+ <version>2.3.1_1</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
Could you please revert these changes, since they are not necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
