luocooong commented on a change in pull request #2238:
URL: https://github.com/apache/drill/pull/2238#discussion_r642082274
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetScan.java
##########
@@ -51,4 +53,57 @@ public void testSuccessFile() throws Exception {
.build()
.run();
}
+
+ @Test
Review comment:
I recommend that :
```java
// DRILL-7934: Fix NullPointerException error when reading parquet files
@Test
```
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScanStatistics.java
##########
@@ -115,7 +118,11 @@ public void collect(Collection<T> metadataList) {
previousCount.setValue(Statistic.NO_COLUMN_STATS);
}
ColumnMetadata columnMetadata =
SchemaPathUtils.getColumnMetadata(schemaPath, metadata.getSchema());
- TypeProtos.MajorType majorType = columnMetadata != null ?
columnMetadata.majorType() : null;
+ // DRILL-7934
+ // base on
metastore/metastore-api/src/main/java/org/apache/drill/metastore/util/SchemaPathUtils.java#145
Review comment:
I recommend move the line 121-124 to description section of PR (On
Github page).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
