luocooong commented on a change in pull request #2241:
URL: https://github.com/apache/drill/pull/2241#discussion_r644055051
##########
File path:
contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithH2IT.java
##########
@@ -53,6 +54,10 @@
@BeforeClass
public static void init() throws Exception {
startCluster(ClusterFixture.builder(dirTestWatcher));
+ // Force timezone to UTC for these tests.
Review comment:
Actually, I really don't recommend setup the timezone in UT. However, I
changed my mind when refactor the image plugin. Because the library of image
not supported to set timezone by API (Get the timezone of host automatically),
the unit tests required to compare the value and only provide the constant
value by `testBuilder().jsonBaselineFile()`. So, I have to set the timezone in
the unit tests. I think there's no problem if we have to pass the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
