vdiravka commented on a change in pull request #2287:
URL: https://github.com/apache/drill/pull/2287#discussion_r684057384
##########
File path:
contrib/storage-cassandra/src/test/java/org/apache/drill/exec/store/cassandra/TestCassandraSuit.java
##########
@@ -65,7 +66,10 @@ public static void tearDownCluster() {
private static void startCassandra() {
cassandra = new CassandraContainer<>("cassandra")
- .withInitScript("queries.cql");
+ .withInitScript("queries.cql")
+ .withStartupTimeout(Duration.ofMinutes(2))
Review comment:
Please keep same indent for the methods call chain. For example:
```
HiveParquetTableMetadataProvider metadataProvider = builder
.withEntries(entries)
.withHivePartitionHolder(hivePartitionHolder)
.withHiveStoragePlugin(hiveStoragePlugin)
.withReaderConfig(readerConfig)
.withSchema(schema)
.build();
```
https://github.com/apache/drill/blob/4aefcef2b665c5737471664912a26ef6ed9a6cfc/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveDrillNativeParquetScan.java#L78
##########
File path:
contrib/storage-cassandra/src/test/java/org/apache/drill/exec/store/cassandra/TestCassandraSuit.java
##########
@@ -65,7 +66,10 @@ public static void tearDownCluster() {
private static void startCassandra() {
cassandra = new CassandraContainer<>("cassandra")
- .withInitScript("queries.cql");
+ .withInitScript("queries.cql")
+ .withStartupTimeout(Duration.ofMinutes(2))
+ .withEnv("CASSANDRA_SNITCH", "GossipingPropertyFileSnitch") // Tune
Cassandra options for faster startup
+ .withEnv("JVM_OPTS", "-Dcassandra.skip_wait_for_gossip_to_settle=0
-Dcassandra.initial_token=0");
Review comment:
Possibly we can do event better here:
```
-Dcassandra.skip_wait_for_gossip_to_settle=0
-Dcassandra.load_ring_state=false -Dcassandra.initial_token=1
-Dcassandra.num_tokens=nil
-Dcassandra.allocate_tokens_for_local_replication_factor=nil
```
https://github.com/sky-uk/cassandra-operator/issues/103#issuecomment-499040927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
