cgivre commented on a change in pull request #2293:
URL: https://github.com/apache/drill/pull/2293#discussion_r686399026
##########
File path:
contrib/storage-http/src/test/java/org/apache/drill/exec/store/http/TestHttpPlugin.java
##########
@@ -585,7 +585,7 @@ public void testSlowResponse() throws Exception {
server.enqueue(
new MockResponse().setResponseCode(200)
.setBody(TEST_JSON_RESPONSE)
- .throttleBody(64, 4, TimeUnit.SECONDS)
Review comment:
@vdiravka
Thanks for the PR. For this test, we could also set the timeout for the
plugin config to be say 1 seconds and set the throttle to be 2. Just a
suggestion. The goal with this test was just to make sure the plugin does in
fact time out and throw the appropriate exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
