cgivre commented on a change in pull request #2310:
URL: https://github.com/apache/drill/pull/2310#discussion_r707580483
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/impl/SingleVectorState.java
##########
@@ -258,10 +258,12 @@ public int allocate(int cardinality) {
* row, or for some previous row, depending on exactly when and where the
* overflow occurs.
*
- * @param sourceStartIndex the index of the row that caused the overflow, the
+ * sourceStartIndex: the index of the row that caused the overflow, the
* values of which should be copied to a new "look-ahead" vector. If the
* vector is an array, then the overflowIndex is the position of the first
* element to be moved, and multiple elements may need to move
+ *
+ * @param cardinality
Review comment:
Yes please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
