cgivre commented on a change in pull request #2327:
URL: https://github.com/apache/drill/pull/2327#discussion_r725565805
##########
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/CapitalizingJdbcSchema.java
##########
@@ -93,6 +110,65 @@ void setHolder(SchemaPlus plusOfThis) {
return inner.getTableNames();
}
+
+ @Override
+ public CreateTableEntry createNewTable(String tableName, List<String>
partitionColumns, StorageStrategy strategy) {
+ if (! plugin.getConfig().isWritable()) {
+ throw UserException
+ .dataWriteError()
+ .message(plugin.getName() + " is not writable.")
+ .build(logger);
+ }
+
+ return new CreateTableEntry() {
+
+ @Override
+ public Writer getWriter(PhysicalOperator child) throws IOException {
+ String tableWithSchema =
JdbcQueryBuilder.buildCompleteTableName(tableName, catalog, schema);
+ return new JdbcWriter(child, tableWithSchema, inner, plugin);
+ }
+
+ @Override
+ public List<String> getPartitionColumns() {
+ return Collections.emptyList();
+ }
+ };
+ }
+
+ @Override
+ public void dropTable(String tableName) {
+ String tableWithSchema =
JdbcQueryBuilder.buildCompleteTableName(tableName, catalog, schema);
+ String dropTableQuery = String.format("DROP TABLE %s", tableWithSchema);
+ dropTableQuery = JdbcDDLQueryUtils.cleanDDLQuery(dropTableQuery,
plugin.getDialect());
+
+ try {
+ Connection conn = inner.getDataSource().getConnection();
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
