cgivre commented on a change in pull request #2327:
URL: https://github.com/apache/drill/pull/2327#discussion_r730405118
##########
File path:
contrib/storage-jdbc/src/main/java/org/apache/drill/exec/store/jdbc/JdbcCatalogSchema.java
##########
@@ -56,7 +56,7 @@
while (set.next()) {
final String catalogName = set.getString(1);
CapitalizingJdbcSchema schema = new CapitalizingJdbcSchema(
- getSchemaPath(), catalogName, source, dialect, convention,
catalogName, null, caseSensitive);
+ getSchemaPath(), catalogName, source, dialect, convention,
catalogName, null, caseSensitive, convention.getPlugin());
Review comment:
Done. I had to make change `CapitalizingJdbcPlugin` to require a
`DrillJdbcConvention` rather than the Calcite `JdbcConvention`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
