vdiravka commented on a change in pull request #2344:
URL: https://github.com/apache/drill/pull/2344#discussion_r733677597
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/streams/StreamsFormatPluginConfig.java
##########
@@ -31,6 +31,16 @@ public int hashCode() {
return 47;
}
+ @Override
+ public boolean equals (Object that) {
Review comment:
```suggestion
public boolean equals(Object that) {
```
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBFormatPluginConfig.java
##########
@@ -53,6 +53,30 @@ public int hashCode() {
return result;
}
+ @Override
+ public boolean equals(Object obj) {
Review comment:
What about equals and hashcode annotation from Lombok?
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/StoragePlugins.java
##########
@@ -17,12 +17,8 @@
*/
package org.apache.drill.exec.planner.logical;
-import java.util.Collection;
-import java.util.HashMap;
-import java.util.Iterator;
-import java.util.Map;
+import java.util.*;
Review comment:
Do not use imports with stars
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/TableFormatPluginConfig.java
##########
@@ -31,5 +31,10 @@ public boolean equals(Object obj) {
return impEquals(obj);
}
+ @Override
+ public int hashCode() {
+ return 613;
Review comment:
Why constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
