paul-rogers commented on pull request #2333: URL: https://github.com/apache/drill/pull/2333#issuecomment-949869843
@rymarm, thanks for the detailed explanations! I wonder, in addition to your other work, can you fix up the missing functionality in the current heartbeat implementation? Seems silly for us to send heartbeats, but ignore the results. That way, for Drill versions older than the one with your server-side fix, we'd know `isValid()` within the last 15 seconds, which seems pretty good. Also, can your new work simply use the existing ping mechanism so we don't have to change the server? That would eliminate the RPC versioning issues. I look forward to your remaining fix, then I'll give the code another review. Ping me when you're ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
