LGTM. +1
> 在 2021年11月2日，21:33，James Turton <[email protected]> 写道： > > |Hi Charles|| > || > ||When I first took this idea to Paul I proposed that we attribute authorship > but he declined that bit. We do have the Git history for the wiki, and the > lines shown for the last Git commit to affect a page are quite visible in the > wiki, e.g.|| > || > ||> Paul Rogers edited this page on 27 Apr 2020.|| > || > ||But those will of course fade over time as others add commits. I did not > argue the matter, just concluded with "if you ever change your mind, tell us > and we will add an attribution". To give you an idea of what Cong's table of > authors might look like if it was ranked by number of commits, here's the > output of git shortlog -sn.|| > || > || 752 Paul Rogers|| > || 8 Mohamed Gelbana|| > || 1 Boaz Ben-Zvi|| > || 1 Dobes Vandermeer|| > || 1 Muhammad Gelbana|| > || > ||The size of Paul's contribution is humbling.||We can still add a page with > author names (with or without any edit stats) on it, I wouldn't expect Paul > to object. He seemed mostly to be saying "it's not necessary for me". > ||| > >> On 2021/11/01 02:03, luoc wrote: >> That is good advice. I recommend adding a page (or a table list) listing all >> the wiki contributors. Paul is the founding member. >> >>>> 在 2021年11月1日，01:45，Charles Givre<[email protected]> 写道： >>> >>> This is great! Can we give @paul-rogers some credit on these pages? Also >>> I'd really love to merge the existing dev docs in the github repo with the >>> wiki docs. I'm willing to help with that, time permitting. >>> -- C >>> >>>> On Oct 30, 2021, at 5:59 AM, luoc<[email protected]> wrote: >>>> >>>> >>>> It cannot get any better than this! >>>> >>>>> 2021年10月30日 下午5:39，James Turton<[email protected]> 写道： >>>>> >>>>> I'm delighted to report that the gold mine of developer information that >>>>> is Paul Rogers' Drill wiki has just formed the basis of a new Drill >>>>> developer wiki. >>>>> >>>>> https://github.com/apache/drill/wiki >>>>> >>>>> The community would like to thank Paul for this sizeable and valuable >>>>> contribution, and for his blessing that we proceed to merge the work >>>>> under the normal Apache contributor terms. >>>>> >>>>> Our work here is just beginning. A wiki is never a completed work, but >>>>> requires ongoing editing from all of us to remain complete and accurate. >>>>> Let's go on to make it the powerful asset for future Drill developers >>>>> that it certainly can be. >>>>> >>>>> James >>>>>
