luocooong commented on a change in pull request #2383:
URL: https://github.com/apache/drill/pull/2383#discussion_r753689452
##########
File path: contrib/storage-splunk/src/test/resources/logback-test.xml.bak
##########
@@ -1,59 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
Review comment:
Could you please move this file to `/dev-support` folder? this is a good
reference template file for the test (than the one in the
`/drill-common/src/test/resources/` folder). Thanks.
##########
File path: contrib/storage-splunk/src/test/resources/logback-test.xml.bak
##########
@@ -1,59 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
Review comment:
Files in folder `/dev-support` are not compiled, built, and run-time,
and exist to support development, so no test files are added.
##########
File path: contrib/storage-splunk/src/test/resources/logback-test.xml.bak
##########
@@ -1,59 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
Review comment:
Perhaps I didn't make that clear. This test file is more representative
and can retain only the log output information for the submodules. eg,
`<logger name="org.apache.drill.exec.store.splunk">`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
