dzamo commented on a change in pull request #2386: URL: https://github.com/apache/drill/pull/2386#discussion_r755985119
########## File path: contrib/format-sas/src/main/java/org/apache/drill/exec/store/sas/SasFormatConfig.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.drill.exec.store.sas; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonTypeName; + +import org.apache.drill.common.PlanStringBuilder; +import org.apache.drill.common.logical.FormatPluginConfig; +import org.apache.drill.shaded.guava.com.google.common.collect.ImmutableList; + +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +@JsonTypeName(SasFormatPlugin.DEFAULT_NAME) +@JsonInclude(JsonInclude.Include.NON_DEFAULT) +public class SasFormatConfig implements FormatPluginConfig { + private final List<String> extensions; + + // Omitted properties take reasonable defaults + @JsonCreator + public SasFormatConfig(@JsonProperty("extensions") List<String> extensions) { + this.extensions = extensions == null ? Collections.singletonList("sas7bdat") : ImmutableList.copyOf(extensions); + } + + @JsonInclude(JsonInclude.Include.NON_DEFAULT) + public List<String> getExtensions() { + return extensions; + } + + @Override + public int hashCode() { Review comment: I think hashCode and equals could be Lomboked if that's something we're defaulting to these days. ########## File path: contrib/format-sas/README.md ########## @@ -0,0 +1,34 @@ +# Format Plugin for SAS Files +This format plugin enables Drill to read SAS files. (sas7bdat) + +## Data Types +The SAS format supports the `VARCHAR`, `LONG`, `DOUBLE` and `DATE` formats. Review comment: ```suggestion The SAS format supports the `VARCHAR`, `LONG`, `DOUBLE` and `DATE` types. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
