luocooong opened a new pull request #2389:
URL: https://github.com/apache/drill/pull/2389


   # [DRILL-8060](https://issues.apache.org/jira/browse/DRILL-8060): Avoid the 
NPE in the Filter of Iceberg Implementor
   
   ## Description
   Query the phoenix data using the filter got the NPE (stack error at the 
Iceberg format module), because the ***#canImplement(Filter filter)*** might 
accept a `JdbcTableScan` (or an object that extend the TableScan of Calcite), 
then ***#getDrillTable(TableScan)*** will get the null.
   
   ```
   Caused by: java.lang.NullPointerException: null
           at 
org.apache.drill.exec.store.iceberg.plan.IcebergPluginImplementor.canImplement(IcebergPluginImplementor.java:102)
           at 
org.apache.drill.exec.store.plan.rule.PluginConverterRule.matches(PluginConverterRule.java:64)
           at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.matchRecurse(VolcanoRuleCall.java:263)
           at 
org.apache.calcite.plan.volcano.VolcanoRuleCall.match(VolcanoRuleCall.java:247)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.fireRules(VolcanoPlanner.java:1566)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1840)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:848)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:864)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:92)
           at 
org.apache.calcite.rel.AbstractRelNode.onRegister(AbstractRelNode.java:329)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.registerImpl(VolcanoPlanner.java:1701)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.register(VolcanoPlanner.java:848)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.ensureRegistered(VolcanoPlanner.java:864)
           at 
org.apache.calcite.plan.volcano.VolcanoPlanner.changeTraits(VolcanoPlanner.java:531)
           at 
org.apache.calcite.tools.Programs$RuleSetProgram.run(Programs.java:324)
           at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:405)
           at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.transform(DefaultSqlHandler.java:351)
           at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToRawDrel(DefaultSqlHandler.java:245)
           at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.convertToDrel(DefaultSqlHandler.java:308)
           at 
org.apache.drill.exec.planner.sql.handlers.DefaultSqlHandler.getPlan(DefaultSqlHandler.java:173)
           at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getQueryPlan(DrillSqlWorker.java:283)
           at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPhysicalPlan(DrillSqlWorker.java:163)
           at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.convertPlan(DrillSqlWorker.java:128)
           at 
org.apache.drill.exec.planner.sql.DrillSqlWorker.getPlan(DrillSqlWorker.java:93)
           at 
org.apache.drill.exec.work.foreman.Foreman.runSQL(Foreman.java:593)
           at org.apache.drill.exec.work.foreman.Foreman.run(Foreman.java:274)
           ... 3 common frames omitted 
   ```
   
   ## Documentation
   N/A
   
   ## Testing
   - Phoenix storage can using the Filter pushdown.
   - All of the tests are passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to