jnturton commented on pull request #2388: URL: https://github.com/apache/drill/pull/2388#issuecomment-1005646342
@vvysotskyi one specific question that arises in this PR is that of closing schema objects. Before this PR, `SchemaTreeProvider#close()` would recursively access the entire schema tree in order to call close on each schema object. This resulted in a lookup of every storage plugin and then a call to `registerSchemas()` on it, even if the plugin did not participate in the query being run. To avoid this I've made `SchemaTreeProvider#close()` a no-op but I'm not sure what the consequences of this might be. IIRC the one implementation of `SchemaPlus#close()` I did check in Calcite was itself a no-op, making this change harmless. But there could be other implementations of `SchemaPlus#close()`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
