Leon-WTF commented on a change in pull request #2416:
URL: https://github.com/apache/drill/pull/2416#discussion_r780648058
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
##########
@@ -416,16 +417,25 @@ public void setup() {
@Override
public void eval() {
- if (index.value < 1) {
+ if (index.value == 0) {
Review comment:
> Sigh, 1-based indexing. I think the logic you chose in this PR for
non-positive index values is the best we can do, considering.
@jnturton Hi James, anything wrong here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
