pjfanning commented on a change in pull request #2426:
URL: https://github.com/apache/drill/pull/2426#discussion_r783954120
##########
File path:
contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
##########
@@ -312,41 +311,31 @@ private void getColumnHeaders(SchemaBuilder builder) {
//If there are no headers, create columns names of field_n
if (readerConfig.headerRow == -1) {
String missingFieldName;
- int i = 0;
- for (Cell c : currentRow) {
- missingFieldName = MISSING_FIELD_NAME_HEADER + (i + 1);
+ for (short colNum = 0; colNum < currentRow.getLastCellNum(); colNum++) {
Review comment:
getLastCellNum returns a short so matching the type to that - excel only
allows 16,384 columns and Short.MAX_VALUE = 32767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
