vdiravka commented on a change in pull request #2432:
URL: https://github.com/apache/drill/pull/2432#discussion_r795053250
##########
File path: pom.xml
##########
@@ -1802,7 +1803,7 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.39.Final</version>
+ <version>2.0.47.Final</version>
Review comment:
48 is available now
##########
File path: pom.xml
##########
@@ -104,7 +104,7 @@
<license.skip>true</license.skip>
<docker.repository>apache/drill</docker.repository>
<antlr.version>4.8-1</antlr.version>
- <maven.version>3.6.3</maven.version>
+ <maven.version>3.8.4</maven.version>
Review comment:
Could you update the correspondent maven.md doc?
##########
File path: exec/jdbc-all/pom.xml
##########
@@ -33,7 +33,7 @@
"package.namespace.prefix" equals to "oadd.". It can be overridden if
necessary within any profile -->
<properties>
<package.namespace.prefix>oadd.</package.namespace.prefix>
- <jdbc-all-jar.maxsize>46700000</jdbc-all-jar.maxsize>
+ <jdbc-all-jar.maxsize>44100000</jdbc-all-jar.maxsize>
Review comment:
gj
##########
File path: distribution/pom.xml
##########
@@ -199,28 +199,30 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>linux-x86_64-fedora</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <version>2.0.47.Final</version>
<classifier>osx-x86_64</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-tcnative</artifactId>
- <version>2.0.1.Final</version>
+ <!-- bump warning: windows-x86_64 jars apparently stopped being published
+ after 2.0.36, see
https://repo1.maven.org/maven2/io/netty/netty-tcnative/ -->
+ <version>2.0.36.Final</version>
Review comment:
What about 2.0.48.Final ?
https://mvnrepository.com/artifact/io.netty/netty-tcnative/2.0.48.Final
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestAnalyze.java
##########
@@ -492,7 +492,7 @@ public void testHistogramWithDataTypes1() throws Exception {
.match();
query = "select 1 from dfs.tmp.employee1 where store_id < 15";
- String[] expectedPlan2 = {"Filter\\(condition.*\\).*rowcount = 676.*,.*",
+ String[] expectedPlan2 = {"Filter\\(condition.*\\).*rowcount = 699.*,.*",
"Scan.*columns=\\[`store_id`\\].*rowcount = 1128.0.*"};
Review comment:
Do you know why rowcount is changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
