vdiravka commented on a change in pull request #2445:
URL: https://github.com/apache/drill/pull/2445#discussion_r804584121
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/PluginHandle.java
##########
@@ -30,7 +31,7 @@
* long Drillbit start times. Plugin creation is synchronized as is closing.
* <p>
* A handle has a type used to determine which operations are allowed on
- * the handle. For example, inrinsic (system) plugins cannot be deleted or
+ * the handle. For example, intrinsic (system) plugins cannot be deleted or
* disabled.
*
* <h4>Caveats</h4>
Review comment:
Please check javadoc for`PluginHandle`.
The plugin instances are not created separately for every user. Usually the
instances are reused by different users (see an example for user1, user2, user3
in javadoc).
Therefore UserSession can't be kept with current plugins.
There is a solution In #2251 to have separate `StoragePluginRegistryImpl`
for every session. That can be used for per-user credentials then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
