vdiravka commented on a change in pull request #2463:
URL: https://github.com/apache/drill/pull/2463#discussion_r809331597
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/compression/AirliftBytesInputCompressor.java
##########
@@ -159,13 +160,16 @@ public void decompress(ByteBuffer input, int
compressedSize, ByteBuffer output,
@Override
public void release() {
- logger.debug(
- "will release {} allocated buffers.",
- this.allocatedBuffers.size()
- );
+ int bufCount = allocatedBuffers.size();
- while (!this.allocatedBuffers.isEmpty()) {
- this.allocator.release(allocatedBuffers.pop());
+ // LIFO release order to try to reduce memory fragmentation.
+ int i = 0;
+ while (!allocatedBuffers.isEmpty()) {
+ allocator.release(allocatedBuffers.pop());
+ i++;
}
+ assert bufCount == i;
Review comment:
It is better to write assertion message always. It helps to understand
the error in StackTrace better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
