jnturton commented on pull request #2469:
URL: https://github.com/apache/drill/pull/2469#issuecomment-1046664690


   @agozhiy an alternative to @luocooong's importing java.time classes from JDK 
11 is to write a fallback along the lines of
   
   ```
   try {
     ISO_OFFSET_DATE_TIME.parse(...);
   } catch (DateTimeParseException ex) {
     // fall back to the parsing code that was present in VectorOutput before 
commit dc8cbb55
     // or to one of the parser patterns suggested for JDK 8 [1][2].  Please 
include a comment
     // explaining that the fallback is for JDK 8 if you use this approach.
   }  
     
   [1] 
https://stackoverflow.com/questions/46487403/java-8-date-and-time-parse-iso-8601-string-without-colon-in-offset
   [2] 
https://stackoverflow.com/questions/43360852/cannot-parse-string-in-iso-8601-format-lacking-colon-in-offset-to-java-8-date


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to