paul-rogers commented on a change in pull request #2499:
URL: https://github.com/apache/drill/pull/2499#discussion_r833963288
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestInboundImpersonation.java
##########
@@ -156,22 +159,25 @@ public void unauthorizedTarget() throws Exception {
@Test
public void invalidPolicy() throws Exception {
- thrownException.expect(new
UserExceptionMatcher(UserBitShared.DrillPBError.ErrorType.VALIDATION,
- "Invalid impersonation policies."));
+ String query = "ALTER SYSTEM SET `%s`='%s'";
Review comment:
Just picking one test file at random, here's an example of the idea:
https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/exec/compile/TestLargeFileCompilation.java#L273
It is not about the exception handling, which is fine. It's just about the
busy-work of formatting the `ALTER SYSTEM SET` commands over and over.
Again, without looking closely, I don't know if this test happens to use one
of the two clients that have these methods. If not, then you have to do things
the tedious way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
