vvysotskyi commented on code in PR #2527:
URL: https://github.com/apache/drill/pull/2527#discussion_r862758310
##########
exec/java-exec/src/main/java/org/apache/drill/exec/compile/ClassTransformer.java:
##########
@@ -240,7 +240,7 @@ public Class<?> getImplementationClass(
Map<String, Pair<byte[], ClassNode>> classesToMerge = Maps.newHashMap();
for (byte[] clazz : implementationClasses) {
totalBytecodeSize += clazz.length;
- final ClassNode node = AsmUtil.classFromBytes(clazz,
ClassReader.EXPAND_FRAMES);
+ ClassNode node = AsmUtil.classFromBytes(clazz,
ClassReader.SKIP_FRAMES);
Review Comment:
We use `ClassWriter#COMPUTE_FRAMES` for class writer, so according to the
docs, `ClassReader.SKIP_FRAMES` is useful to avoid visiting frames that will be
ignored and recomputed from the scratch. I had to set it in this PR because
Janino has changed something in its bytecode, so it fails with the
`ClassReader.EXPAND_FRAMES` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
