jnturton commented on code in PR #2528:
URL: https://github.com/apache/drill/pull/2528#discussion_r863767452
##########
logical/src/main/java/org/apache/drill/common/logical/StoragePluginConfig.java:
##########
@@ -105,8 +106,8 @@ public enum AuthMode {
*/
USER_TRANSLATION;
- public static AuthMode parseOrDefault(String authMode) {
- return !Strings.isNullOrEmpty(authMode) ?
AuthMode.valueOf(authMode.toUpperCase()) : DRILL_PROCESS;
+ public static AuthMode parseOrDefault(String authMode, AuthMode defavlt) {
Review Comment:
@cgivre I did wonder if that variable name would get a reaction. `default`
is a reserved word in Java so this is a little Roman alphabet hack like writing
`Class clazz;`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
