jnturton commented on PR #2542: URL: https://github.com/apache/drill/pull/2542#issuecomment-1122604719
> LGTM +1 > This is really a minor update, but is it worth adding a unit test? We can skip it if it is a major hassle. I think a unit test would need a new DB2 testcontainer or a mocked JDBC Connection that returns a null like DB2 does. The cost/benefit of doing those to exercise a null test doesn't look good to me, but there may be some tricks I don't know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
