jnturton commented on code in PR #2535:
URL: https://github.com/apache/drill/pull/2535#discussion_r871526487
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushRowKeyJoinToScanRule.java:
##########
@@ -463,8 +463,9 @@ private static boolean isRowKeyColumn(int index, RelNode
rel) {
}
// If no exprs present in projection the column index remains the same
in the child.
// Otherwise, the column index is the `RexInputRef` index.
- if (curRel != null && curRel instanceof DrillProjectRel) {
- List<RexNode> childExprs = curRel.getChildExps();
+ if (curRel instanceof DrillProjectRel) {
Review Comment:
I didn't realise that an `instanceof` already provides a null check, nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
