jnturton commented on code in PR #2538:
URL: https://github.com/apache/drill/pull/2538#discussion_r872306477
##########
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillPushProjectIntoScanRule.java:
##########
@@ -46,16 +46,28 @@
public class DrillPushProjectIntoScanRule extends RelOptRule {
public static final RelOptRule INSTANCE =
new DrillPushProjectIntoScanRule(LogicalProject.class,
- EnumerableTableScan.class,
+ DirPrunedTableScan.class,
"DrillPushProjectIntoScanRule:enumerable") {
@Override
protected boolean skipScanConversion(RelDataType projectRelDataType,
TableScan scan) {
- // do not allow skipping conversion of EnumerableTableScan to
DrillScanRel if rule is applicable
+ // do not allow skipping conversion of DirPrunedTableScan to
DrillScanRel if rule is applicable
return false;
}
};
+ public static final RelOptRule LOGICAL_INSTANCE =
+ new DrillPushProjectIntoScanRule(LogicalProject.class,
+ LogicalTableScan.class,
+ "DrillPushProjectIntoScanRule:none") {
+
+ @Override
+ protected boolean skipScanConversion(RelDataType projectRelDataType,
TableScan scan) {
+ // do not allow skipping conversion of EnumerableTableScan to
DrillScanRel if rule is applicable
Review Comment:
```suggestion
// do not allow skipping conversion of LogicalTableScan to
DrillScanRel if rule is applicable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
