cgivre commented on code in PR #2544:
URL: https://github.com/apache/drill/pull/2544#discussion_r873575333
##########
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/StorageResources.java:
##########
@@ -212,61 +195,15 @@ public Response enablePlugin(@PathParam("name") String
name, @PathParam("val") B
@Consumes(MediaType.APPLICATION_JSON)
@Produces(MediaType.APPLICATION_JSON)
public Response updateRefreshToken(@PathParam("name") String name,
OAuthTokenContainer tokens) {
Review Comment:
I had debated removing the endpoints in `StorageResources`. The only reason
I left them was in case someone was using these endpoints, then we'd have a
breaking change when they upgraded. What if I mark them as deprecated?
As a point of clarification, the reason I moved them to
`CredentialResources` was because the credentials page allows a user to update
their creds. The `StorageResources` requires admin access, whereas the
credentials page only requires an authorized user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
