jnturton commented on code in PR #32:
URL: https://github.com/apache/drill-site/pull/32#discussion_r946497802
##########
_docs/en/performance-tuning/070-monitoring-metrics.md:
##########
@@ -35,14 +35,41 @@ In `$DRILL_HOME/conf/drill-env.sh`, set the
`drill.metrics.jmx.enabled` option t
export DRILLBIT_JAVA_OPTS="$DRILLBIT_JAVA_OPTS
-Ddrill.metrics.jmx.enabled=false"
+## Metrics with Prefix
+After Drill 2.0.0, all metrics are grouped by 6 categories, which are:
+
+* drill
+* jvm
+* memory
+* threads
+* cached-threads
+* class
+
+And those 6 categories are appended to the metrics as prefix, which make Drill
easier to maintenance.
Review Comment:
```suggestion
These categories are prepended to the Drill metric names for easier
maintenance.
```
##########
_docs/en/performance-tuning/070-monitoring-metrics.md:
##########
@@ -35,14 +35,41 @@ In `$DRILL_HOME/conf/drill-env.sh`, set the
`drill.metrics.jmx.enabled` option t
export DRILLBIT_JAVA_OPTS="$DRILLBIT_JAVA_OPTS
-Ddrill.metrics.jmx.enabled=false"
+## Metrics with Prefix
+After Drill 2.0.0, all metrics are grouped by 6 categories, which are:
+
+* drill
+* jvm
+* memory
+* threads
+* cached-threads
+* class
+
+And those 6 categories are appended to the metrics as prefix, which make Drill
easier to maintenance.
+
+For example, in old version, some metrics in Gauges are:
+
+* count
+* direct.count
+* blocked.count
+* new.count
+
+which the names are similar and hard to distinguish,
+
+* cached-threads.count
+* jvm.direct.count
+* threads.blocked.count
+* threads.new.count
+
+after add the categorized prefix, make the metrics to be understood easily.
Review Comment:
```suggestion
```
##########
_docs/en/performance-tuning/070-monitoring-metrics.md:
##########
@@ -35,14 +35,41 @@ In `$DRILL_HOME/conf/drill-env.sh`, set the
`drill.metrics.jmx.enabled` option t
export DRILLBIT_JAVA_OPTS="$DRILLBIT_JAVA_OPTS
-Ddrill.metrics.jmx.enabled=false"
+## Metrics with Prefix
+After Drill 2.0.0, all metrics are grouped by 6 categories, which are:
Review Comment:
```suggestion
Starting with Drill 2.0.0, all metrics are grouped into the following 6
categories.
```
##########
_docs/en/performance-tuning/070-monitoring-metrics.md:
##########
@@ -35,14 +35,41 @@ In `$DRILL_HOME/conf/drill-env.sh`, set the
`drill.metrics.jmx.enabled` option t
export DRILLBIT_JAVA_OPTS="$DRILLBIT_JAVA_OPTS
-Ddrill.metrics.jmx.enabled=false"
+## Metrics with Prefix
+After Drill 2.0.0, all metrics are grouped by 6 categories, which are:
+
+* drill
+* jvm
+* memory
+* threads
+* cached-threads
+* class
+
+And those 6 categories are appended to the metrics as prefix, which make Drill
easier to maintenance.
+
+For example, in old version, some metrics in Gauges are:
+
+* count
+* direct.count
+* blocked.count
+* new.count
+
+which the names are similar and hard to distinguish,
Review Comment:
```suggestion
now have the following, more easily recognised names.
```
##########
_docs/en/performance-tuning/070-monitoring-metrics.md:
##########
@@ -35,14 +35,41 @@ In `$DRILL_HOME/conf/drill-env.sh`, set the
`drill.metrics.jmx.enabled` option t
export DRILLBIT_JAVA_OPTS="$DRILLBIT_JAVA_OPTS
-Ddrill.metrics.jmx.enabled=false"
+## Metrics with Prefix
+After Drill 2.0.0, all metrics are grouped by 6 categories, which are:
+
+* drill
+* jvm
+* memory
+* threads
+* cached-threads
+* class
+
+And those 6 categories are appended to the metrics as prefix, which make Drill
easier to maintenance.
+
+For example, in old version, some metrics in Gauges are:
Review Comment:
```suggestion
For example, the metric names
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
